-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling with the main log in view #817
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, need to look more into it. For now just a comment with an idea to simplify.
|
||
@media screen and (min-width: 600px) { | ||
.PreSessionScreen { | ||
max-height: calc(100% - 30px - 80px); /* removing padding and margin */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea, but would this be simpler if we use box-sizing: content-box
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ^^'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't work because of the margin, I still need to had the @media.
Scrolling on the main log view
Technical changes :
PreSessionScreen
to overflow him and be scrolled;Should fix this issue (783)