Fix authenticated media breaking in certain SDK scenarios #1188
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MidhunSureshR
force-pushed
the
midhun/fix-audit-media-auth
branch
from
7d726ad
to
2d4c909
Compare
Reading from storage requires fetching the session-id from navigation segment. This is not a good idea since there's no guarantee of such segments existing when hydrogen is used as an SDK.
MidhunSureshR
force-pushed
the
midhun/fix-audit-media-auth
branch
from
2d4c909
to
4fe0f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceWorkerHandlersupplies the access-token to the service worker when needed. We needed the session-id to do this. We took the session-id fromnavigationwhich is a bad idea sincenavigationsegments may not exist when using hydrogen as an SDK.