feat(matrix-stack): add priorityClassName support to component workloads - #1438
Conversation
8ddd4eb to
c58b2e3
Compare
dyff of changes in rendered templates of CI manifestsNo changes in rendered templates |
benbz
left a comment
There was a problem hiding this comment.
Hi, thanks for this. It looks basically perfect. Ideally we would like a global priorityClassName, that's default unset (to avoid changes to existing deploys as you've done for the per-component values) but can be used if people want to change the priorityClassName for everything at once.
To document: all Synapse workers use the same priorityClassName as the main process. I'm not requesting that as a change, I think that's fine for now and we can add per-worker support later if needed.
c58b2e3 to
c857949
Compare
|
Thanks @benbz! Added a global |
|
Done — updated the copyright header to |
As per the suggestion the New Vector Ltd copyright line needed to go too, not just changing the date on the Element Creations Ltd line |
|
Done — dropped the New Vector Ltd copyright line, the header on the new test file is now just |
|
Thank you very much for your contribution! |
Adds an optional
priorityClassNamevalue to every matrix-stack component workload, mirroring the existingnodeSelectorpattern. Default is unset so rendered output is unchanged for existing users. Resolves #1422.Validation (run locally against the repo's own tooling):
helm lintclean;helm templaterenderspriorityClassNamewhen set, byte-identical tomainwhen unsetpytest tests/manifestspasses (2377 passed), including a newtest_pod_priorityClassName.pymirroringtest_pod_nodeSelector.pyreuse lintcompliant,ruffclean, the assemble scripts reproduce with no driftThis is a per-component knob (like
nodeSelector). If you'd prefer a global default with per-component overrides (liketolerations/topologySpreadConstraints), happy to switch.