Skip to content

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 2, 2025

  • Makes suggestions visible again on iPad (and Mac)
    • They were hidden behind the sidebar.
  • Fixes a regression introduced in Accept space invites from a home screen cell. #4554 where the room list would keep the highlight after popping a room.
  • Uses our Backports.swift file for more modifiers.
  • Fixes the silly header bug on macOS by not leading aligning it.
  • Silences some warnings in the project (there's some more in Compound which I haven't done yet as they might involve snapshot updates).

They weren't visible on iPad (hidden behind the sidebar) and I can't find any instance when they're shown where the safe area comes into play.
@pixlwave pixlwave requested a review from a team as a code owner October 2, 2025 17:15
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 2, 2025 17:15
@pixlwave pixlwave added the pr-bugfix for bug fix label Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 60.60606% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.41%. Comparing base (3215f8c) to head (d768951).
⚠️ Report is 7 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ElementX/Sources/Other/SwiftUI/Backports.swift 46.51% 23 Missing ⚠️
...X/Sources/Other/SwiftUI/Views/RoomHeaderView.swift 33.33% 2 Missing ⚠️
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4569      +/-   ##
===========================================
+ Coverage    78.26%   79.41%   +1.14%     
===========================================
  Files          862      863       +1     
  Lines        81188    81474     +286     
===========================================
+ Hits         63545    64705    +1160     
+ Misses       17643    16769     -874     
Flag Coverage Δ
compound 92.67% <100.00%> (?)
unittests 70.85% <59.09%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 2, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

compound-ios/Sources/Compound/Icons/CompoundIcon.swift#L171 - Please use explicit spacing in VStacks. (vstack_spacing)

⚠️

compound-ios/Sources/Compound/Icons/CompoundIcon.swift#L173 - Please use explicit spacing in HStacks. (hstack_spacing)

⚠️

compound-ios/Sources/Compound/Icons/CompoundIcon.swift#L222 - Please use explicit spacing in VStacks. (vstack_spacing)

Generated by 🚫 Danger Swift against d768951

@pixlwave pixlwave mentioned this pull request Oct 2, 2025
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

Copy link

sonarqubecloud bot commented Oct 3, 2025

@pixlwave pixlwave merged commit 6377d9b into develop Oct 3, 2025
15 of 17 checks passed
@pixlwave pixlwave deleted the doug/tweaks branch October 3, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants