Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastlane fails resetting the right simulator, use device instead of destination. #3493

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Fastlane fails resetting the right simulator, use device instead of destination. #3493

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83477bb
Fastlane fails resetting the right simulator, use `device` instead of…
stefanceriu Nov 7, 2024
b09a65b
Fix ElementCall UI test
stefanceriu Nov 7, 2024
d6d5241
Fix useSessionScreen test snapshots.
stefanceriu Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UITests/Sources/UserSessionScreenTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class UserSessionScreenTests: XCTestCase {
let textField = app.textFields["Display name"]
XCTAssert(textField.waitForExistence(timeout: 10))

let joinButton = app.buttons["Join call now"]
let joinButton = app.buttons["Continue"]
XCTAssert(joinButton.waitForExistence(timeout: 10))
}
}
14 changes: 7 additions & 7 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ lane :unit_tests do |options|

run_tests(
scheme: "UnitTests",
destination: "platform=iOS Simulator,name=iPhone 16,OS=18.0",
device: "iPhone 16 (18.0)",
ensure_devices_found: true,
result_bundle: true,
number_of_retries: 3,
Expand All @@ -94,7 +94,7 @@ lane :unit_tests do |options|
if !options[:skip_previews]
run_tests(
scheme: "PreviewTests",
destination: "platform=iOS Simulator,name=iPhone SE (3rd generation),OS=18.0",
device: "iPhone SE (3rd generation) (18.0)",
ensure_devices_found: true,
result_bundle: true,
number_of_retries: 3,
Expand All @@ -107,13 +107,13 @@ end

lane :ui_tests do |options|
create_simulator_if_necessary(
name: "iPhone 16",
name: "iPhone 16 (18.0)",
type: "com.apple.CoreSimulator.SimDeviceType.iPhone-16",
runtime: "com.apple.CoreSimulator.SimRuntime.iOS-18-0"
)

create_simulator_if_necessary(
name: "iPad (10th generation)",
name: "iPad (10th generation) (18.0)",
type: "com.apple.CoreSimulator.SimDeviceType.iPad-10th-generation",
runtime: "com.apple.CoreSimulator.SimRuntime.iOS-18-0"
)
Expand All @@ -128,7 +128,7 @@ lane :ui_tests do |options|

run_tests(
scheme: "UITests",
devices: ["iPhone 16", "iPad (10th generation)"],
devices: ["iPhone 16 (18.0)", "iPad (10th generation) (18.0)"],
ensure_devices_found: true,
prelaunch_simulator: true,
result_bundle: true,
Expand All @@ -143,7 +143,7 @@ lane :integration_tests do
clear_derived_data()

create_simulator_if_necessary(
name: "iPhone 16 Pro",
name: "iPhone 16 Pro (18.0)",
type: "com.apple.CoreSimulator.SimDeviceType.iPhone-16-Pro",
runtime: "com.apple.CoreSimulator.SimRuntime.iOS-18-0"
)
Expand All @@ -152,7 +152,7 @@ lane :integration_tests do

run_tests(
scheme: "IntegrationTests",
destination: "platform=iOS Simulator,name=iPhone 16 Pro,OS=18.0",
device: "iPhone 16 Pro (18.0)",
ensure_devices_found: true,
result_bundle: true,
reset_simulator: reset_simulator
Expand Down
Loading