Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Setup Recovery flow from the home screen banner. #3483

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 4, 2024

#3482 introduced a slight regression:

When only a single button is shown on the banner the old flow should still be followed, however the update would always present the key recovery screen directly.

This PR reinstates the previous view action for that button.

Set.up.recovery.mp4
Storage.out.of.sync.mp4

@pixlwave pixlwave requested a review from a team as a code owner November 4, 2024 18:30
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 4, 2024 18:30
Copy link

github-actions bot commented Nov 4, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 766188a

Copy link

sonarcloud bot commented Nov 4, 2024

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@85d497a). Learn more about missing BASE report.
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...View/HomeScreenRecoveryKeyConfirmationBanner.swift 0.00% 2 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 50.00% 1 Missing ⚠️
...ces/Screens/HomeScreen/HomeScreenCoordinator.swift 50.00% 1 Missing ⚠️
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3483   +/-   ##
==========================================
  Coverage           ?   77.63%           
==========================================
  Files              ?      745           
  Lines              ?    61660           
  Branches           ?        0           
==========================================
  Hits               ?    47869           
  Misses             ?    13791           
  Partials           ?        0           
Flag Coverage Δ
unittests 69.27% <22.22%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave added the pr-bugfix for bug fix label Nov 5, 2024
@pixlwave pixlwave merged commit f3a15f7 into develop Nov 5, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/fix-setup-recovery branch November 5, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants