Revert "min macos support" #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 35cbc84.
stefanceriu
requested review from
stefanceriu
and removed request for
Velin92
stefanceriu
approved these changes
Oct 28, 2024
Generated by 🚫 Danger Swift against 48be3fc |
|
pixlwave
added a commit
that referenced
this pull request
Oct 29, 2024
Fixing the version in ASC didn't seem to help, maybe it needs both?
|
Note: This was reapplied on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we didn't need #3451, the issue was that App Store Connect was comparing the uploaded build (which resolves to 14.6) to the one selected for submission to the App Store (which was still resolving to 13.3). Everything should be automatic based on the iOS version.