Enable identity pinning violation notifications unconditionally #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Remove the feature flag we added when this feature seemed unstable.)
|
|
|
pixlwave
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks Andy, welcome to the EXI contributors list 👏
No need to worry about the failures on this one. Enterprise is expected on a fork and the snapshots appear to have got out of sync with some recent string changes. Will merge this and get those fixed in a separate PR.
andybalaam
deleted the
andybalaam/enable-identity-violation-notifs-unconditionally
branch
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable identity pinning violation notifications unconditionally (remove the feature flag we added when this feature seemed unstable).
(Internal issue). Part of the Trust and Decorations work.
In #3394 we disabled identity change notifications based on a default-off feature flag, because we found some bugs in the feature. The bugs are fixed and we think it's time to enable the feature unconditionally.
Pull Request Checklist
UI changes have not been tested at all
.. but this is essentially a revert of #3394 so if someone is able to check I haven't made a basic mistake we might be OK merging it.