Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the flow for changing a recovery key. #3452

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 25, 2024

Closes #3447

I'm not sure why the "Set up" snapshot doesn't match the preview. Tried with a longer timeout but that had no effect - the preview looks like this:

Screenshot 2024-10-25 at 11 39 56 am

@pixlwave pixlwave requested a review from a team as a code owner October 25, 2024 10:40
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 25, 2024 10:40
@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 25, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0b2bfd4

Copy link

sonarcloud bot commented Oct 25, 2024

Copy link

codecov bot commented Oct 25, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
849 1 848 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_joinRoomScreen()

Flake rate in main: 18.18% (Passed 54 times, Failed 12 times)

Stack Traces | 4.55s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.966095 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave requested review from stefanceriu and removed request for Velin92 October 28, 2024 09:32
@pixlwave pixlwave mentioned this pull request Oct 28, 2024
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yey, ship it! 👏

@pixlwave pixlwave merged commit 7c28d97 into develop Oct 28, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/set-up-recovery branch October 28, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Redesign Encryption Settings: Changing the recovery key
2 participants