Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Nov 27, 2025

Content

Inject RoomMemberListDataSource in the presenter constructor.

Motivation and context

RoomMemberListDataSource has an injected constructor, so we can do that. Alternative is to remove @Inject from the constructor.

Screenshots / GIFs

Tests

No expected change in the change role screen

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner November 27, 2025 08:58
@bmarty bmarty requested review from jmartinesp and removed request for a team November 27, 2025 08:58
@bmarty bmarty added the PR-Misc For other changes label Nov 27, 2025
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RdaUQt

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.47%. Comparing base (d40ffe4) to head (597a243).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5822      +/-   ##
===========================================
- Coverage    79.47%   79.47%   -0.01%     
===========================================
  Files         2447     2447              
  Lines        65716    65715       -1     
  Branches      8372     8372              
===========================================
- Hits         52229    52228       -1     
  Misses       10495    10495              
  Partials      2992     2992              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@bmarty bmarty merged commit 29d4dfb into develop Nov 27, 2025
36 of 37 checks passed
@bmarty bmarty deleted the feature/bma/cleanupRoomMemberListDataSource branch November 27, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants