Skip to content

Conversation

@kaylendog
Copy link
Contributor

@kaylendog kaylendog commented Nov 6, 2025

Content

Introduces ComposerAlertLevel and modifies ComposerAlertMolecule to accept a level argument over isCritical. Displays an icon appropriate for the level if no avatar is specified.

Motivation and context

The designs for UX as part of element-hq/element-meta#2875 call for an alert using the info colour palette, which the current component doesn't support.

Screenshots / GIFs

image

Tests

The ComposerAlertLevel.Critical is identical to previous iterations:

image

This was tested using the identity reset alert mechanism.

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 16 API 36.1

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@kaylendog kaylendog self-assigned this Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2025

CLA assistant check
All committers have signed the CLA.

@kaylendog kaylendog added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Nov 6, 2025
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 7, 2025
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but it seems that for some reason (probably because you are using a fork) the screenshot cannot be recorded.
If the PR is ready to be merged (i.e. not a draft anymore), I can merge it in a branch of me and record the screenshot from there.

@kaylendog
Copy link
Contributor Author

The code looks good, but it seems that for some reason (probably because you are using a fork) the screenshot cannot be recorded. If the PR is ready to be merged (i.e. not a draft anymore), I can merge it in a branch of me and record the screenshot from there.

I suspect so; based on what I gleaned from the logs, my fork is missing a Maestro access token. This is ready, so I'll mark this as ready for review, and we can go from there!

@kaylendog kaylendog marked this pull request as ready for review November 7, 2025 15:20
@kaylendog kaylendog requested a review from a team as a code owner November 7, 2025 15:20
@kaylendog kaylendog requested review from bmarty and removed request for a team November 7, 2025 15:20
@kaylendog
Copy link
Contributor Author

kaylendog commented Nov 7, 2025

I'm slightly worried the dark theme info alert doesn't have good contrast - I had similar grievances on element-hq/element-web#31156, which I believe is a question for the design team.

@bmarty bmarty changed the base branch from develop to feature/bma/improveComposerAlertMolecule November 7, 2025 16:01
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. One final comment, then I'll merge your branch to mine to be able to record the screenshots.

@bmarty bmarty merged commit 39aa793 into element-hq:feature/bma/improveComposerAlertMolecule Nov 8, 2025
23 of 25 checks passed
@kaylendog kaylendog deleted the kaylendog/history-sharing/alert branch November 10, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants