Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate display name in notifications #2224 #2295

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 25, 2024

Closes #2224

@bmarty bmarty requested a review from a team as a code owner January 25, 2024 17:45
@bmarty bmarty requested review from ganfra and removed request for a team January 25, 2024 17:45
Copy link
Contributor

github-actions bot commented Jan 25, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/T6jK3H

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f88d96f) 70.05% compared to head (0d35e60) 70.05%.

Files Patch % Lines
...raries/matrix/api/notification/NotificationData.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2295   +/-   ##
========================================
  Coverage    70.05%   70.05%           
========================================
  Files         1351     1351           
  Lines        33139    33145    +6     
  Branches      6867     6868    +1     
========================================
+ Hits         23215    23221    +6     
  Misses        6617     6617           
  Partials      3307     3307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 7636400 into develop Jan 26, 2024
11 checks passed
@bmarty bmarty deleted the feature/bma/disambiguationNotification branch January 26, 2024 07:49
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disambiguation of sender in notification
2 participants