Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chokidar to transitively get newer fsevents #7598

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Oct 25, 2018

The newer version of fsevents compiles successfully with Node 11, while the current version seems to fail during install.

This change does move chokidar to a new major version. The breaking change listed in the change log seems to only affect Windows-style paths, which don't apply here.

Signed-off-by: J. Ryan Stinnett jryans@gmail.com

Signed-off-by: J. Ryan Stinnett <jryans@gmail.com>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! This doesn't explode on my machine and the tests pass, so it seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants