Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package-lock.json for now #7115

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Remove package-lock.json for now #7115

merged 2 commits into from
Aug 1, 2018

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jul 31, 2018

As per #7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.

As per #7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.
@dbkr dbkr requested a review from a team July 31, 2018 10:08
@bwindels
Copy link
Contributor

Cool. Should we also add it to .gitignore for now?

@dbkr
Copy link
Member Author

dbkr commented Aug 1, 2018

Done

@bwindels bwindels merged commit 86a6f1e into master Aug 1, 2018
@bwindels bwindels deleted the dbkr/remove_package_lock branch August 1, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants