Conversation
A module item with no room list of its own (getVisibleRoomBySpaceKey) is a button, such as a dialler, so clicking it runs onSelected without changing the active space.
t3chguy
approved these changes
Sep 24, 2026
ara4n
marked this pull request as draft
September 24, 2026 15:57
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A module can add items to the space panel with
setSpacePanelItem. Clicking one always made it the active space, which for an item that's really a button (the SIP module's dialler) empties the room list and highlights the item as if it were a space.An item that is a space registers its room list with
getVisibleRoomBySpaceKey; one that hasn't is treated as an action:onSelectedruns, the active space stays.🤖 Generated with Claude Code
https://claude.ai/code/session_01XCi2NfsMHKVW8hrve7Rcs5