Add multi-digit support for overlay badges and tests - #33637
Draft
langleyd wants to merge 12 commits into
Draft
Conversation
Fix multi-digit notification badge in Windows taskbar overlay The BadgeOverlayRenderer reused the over-baseImage layout for the standalone 16x16 overlay, which pushed multi-digit badges off the left of the canvas (e.g. "10" rendered as just "0"). Keep the pill inside the canvas bounds in the no-baseImage path and reduce its height for multi-digit counts so the rounded-rect path actually produces a pill. Adds a Playwright test that bundles favicon.ts with esbuild, drives the real BadgeOverlayRenderer in Chromium, and writes the resulting PNGs to disk plus a scaled-up screenshot snapshot for regression detection. Include summary for overlay and favicon
t3chguy
reviewed
May 27, 2026
t3chguy
reviewed
May 27, 2026
Clamp Windows overlay badge at "99+" The Windows taskbar overlay is only 16x16 px and the platform's own notification badges clamp at "99+", so do the same here rather than trying to fit three-digit counts or "1k+" labels into the tiny canvas. Browser-tab favicons are unaffected and still render larger counts.
…ication-favicon # Conflicts: # pnpm-lock.yaml
|
|
langleyd
force-pushed
the
langleyd/fix-notification-favicon
branch
from
August 26, 2026 15:39
5dfd4f5 to
eb14862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multi-digit notification badge in Windows taskbar overlay
Fix multi-digit overlay badges and add tests
The Windows taskbar overlay reused the favicon's pill expansion code, which pushed multi-digit counts off the 16x16 canvas (e.g. "10" showed as just "0"). Always draw a circle and scale the font down for multi-digit counts instead.
Native windows badges only go to 99+ so we can mimic that.
Adds a Playwright test for favicon and overlay use cases.