prevent replay hover from restarting playback - #33364
Merged
ZacksBot merged 4 commits intoMay 4, 2026
Merged
Conversation
…l video on replay
ZacksBot
marked this pull request as ready for review
May 4, 2026 10:09
ZacksBot
marked this pull request as draft
May 4, 2026 10:46
ZacksBot
marked this pull request as ready for review
May 4, 2026 11:15
florianduros
added
T-Defect
backport staging
florianduros
requested changes
May 4, 2026
florianduros
left a comment
florianduros
left a comment
Member
There was a problem hiding this comment.
A unit test could be great
Member
Author
|
florianduros
approved these changes
May 4, 2026
florianduros
removed
the
backport staging
robertpelloni
pushed a commit
to robertpelloni/element-web
that referenced
this pull request
Jun 1, 2026
* prevent replay hover from restarting playback * Fix issue with hover, it's supposed to be a FileBody and not an actual video on replay * Add test for replay video on hover (cherry picked from commit a9edffe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #33324
Video replies were still being overridden to render as a file body in
ReplyTile.The regression appears to come from d791e3f
Fixes : #33324
Now works as intended:
Skarminspelning.2026-05-04.120809.mp4