Skip to content

Collapsible Left Panel - Clicking on separator should expand to 100% when no width is available in settings #33053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MidhunSureshR merged 2 commits into from
Apr 7, 2026
Merged

Collapsible Left Panel - Clicking on separator should expand to 100% when no width is available in settings #33053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cc6018
Expand panel to full width
MidhunSureshR Apr 6, 2026
30d3e34
Write tests
MidhunSureshR Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/viewmodels/structures/ResizerViewModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class ResizerViewModel
public onSeparatorClick = (): void => {
if (this.panelHandle?.isCollapsed()) {
const lastSize = SettingsStore.getValue("RoomList.panelSize");
this.panelHandle.resize(`${lastSize}%`);
this.panelHandle.resize(`${lastSize ?? 100}%`);
}
};

Expand Down
35 changes: 25 additions & 10 deletions apps/web/test/viewmodels/structures/ResizerViewModel-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,33 @@ describe("LeftPanelResizerViewModel", () => {
expect(() => vm.onSeparatorClick()).not.toThrow();
});

it("should expand panel on onSeparatorClick()", () => {
const vm = new ResizerViewModel();
SettingsStore.setValue("RoomList.panelSize", null, SettingLevel.DEVICE, 34);
const mockHandle = {
resize: jest.fn(),
isCollapsed: jest.fn().mockReturnValue(true),
} as unknown as PanelImperativeHandle;
vm.setPanelHandle(mockHandle);
describe("should expand panel on onSeparatorClick()", () => {
it("to last non-zero width that the user set", () => {
const vm = new ResizerViewModel();
SettingsStore.setValue("RoomList.panelSize", null, SettingLevel.DEVICE, 34);
const mockHandle = {
resize: jest.fn(),
isCollapsed: jest.fn().mockReturnValue(true),
} as unknown as PanelImperativeHandle;
vm.setPanelHandle(mockHandle);

vm.onSeparatorClick();
vm.onSeparatorClick();

expect(mockHandle.resize).toHaveBeenCalledWith("34%");
});

expect(mockHandle.resize).toHaveBeenCalledWith("34%");
it("to maximum size of the panel", () => {
const vm = new ResizerViewModel();
const mockHandle = {
resize: jest.fn(),
isCollapsed: jest.fn().mockReturnValue(true),
} as unknown as PanelImperativeHandle;
vm.setPanelHandle(mockHandle);

vm.onSeparatorClick();

expect(mockHandle.resize).toHaveBeenCalledWith("100%");
});
});

it("should set isFocusedViaKeyboard state correctly", () => {
Expand Down
Loading