Remove global h2 css rule in favour of heading styles/components - #32969
Merged
Conversation
and forbid hX elements
add back margin to some legacy headings
…o t3chguy/kill-global-h2
Member
|
FYI, we have a H2 component in compound web |
Member
Author
|
Sure, which is just an alias with defaults for the Heading component. I think using e.g. But in any case the linter doesn't care about H2, but does about 
|
florianduros
approved these changes
Mar 30, 2026
…o t3chguy/kill-global-h2
t3chguy
enabled auto-merge
March 31, 2026 07:58
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Mar 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also forbids use of hX elements in shared-components in favour of Compound's Heading
This rule caused a lot of styling issues in #32968
Screenshots are minor letter-spacing changes