Skip to content

Ensure the incoming verification request appears above the please verify prompt - #32931

Merged
andybalaam merged 1 commit into
developfrom
andybalaam/incoming-verif-above-need-to-verif
Mar 30, 2026
Merged

Ensure the incoming verification request appears above the please verify prompt#32931
andybalaam merged 1 commit into
developfrom
andybalaam/incoming-verif-above-need-to-verif

Conversation

@andybalaam

Copy link
Copy Markdown
Member

Fix #32930

Part of https://github.com/element-hq/crypto-internal/issues/305

Checklist

@andybalaam
andybalaam added this pull request to the merge queue Mar 26, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 26, 2026
@Half-Shot
Half-Shot added this pull request to the merge queue Mar 30, 2026
@andybalaam
andybalaam removed this pull request from the merge queue due to a manual request Mar 30, 2026
@andybalaam

Copy link
Copy Markdown
Member Author

Thanks @Half-Shot but I plan to fix some flakiness before resubmitting this

@andybalaam
andybalaam added this pull request to the merge queue Mar 30, 2026
@andybalaam

Copy link
Copy Markdown
Member Author

Thanks but I plan to fix some flakiness before resubmitting this

When I looked into this further I could not see what had caused the flakiness (maybe the playwright screenshots had been partially cleaned up?) so I am resubmitting.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 30, 2026
@andybalaam
andybalaam force-pushed the andybalaam/incoming-verif-above-need-to-verif branch from c7fcf89 to 0d493c3 Compare March 30, 2026 11:31
@andybalaam
andybalaam added this pull request to the merge queue Mar 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 30, 2026
@andybalaam
andybalaam added this pull request to the merge queue Mar 30, 2026
Merged via the queue into develop with commit 36ddd5e Mar 30, 2026
58 of 64 checks passed
@andybalaam
andybalaam deleted the andybalaam/incoming-verif-above-need-to-verif branch March 30, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Verify this device" toast hides the "Verification requested" toast

3 participants