Add ol override CSS for markdown-body - #31618
Merged
Merged
Conversation
americanrefugee
approved these changes
Jan 5, 2026
americanrefugee
left a comment
There was a problem hiding this comment.
I'm okay with the proposed change. It's actually what I would expect when writing in markdown.
amshakal
approved these changes
Jan 5, 2026
Member
|
Thanks both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14621
This small CSS change affects the marker numbers on ordered lists.
Before this change:
After this change:
As you can see this visually changes the marker numbers to be positioned inside with the content which has the trade-off of not being visually aligned vertically.
Despite this downside I feel it still likely represents one of the cleanest fixes possible to the problem as it doesn't affect HTML structure and will remain unaffected by other upstream changes in how rendering for these lists works. Additionally, it avoids any fragile JavaScript calculations trying to determine how much leading padding is required for a given list of numbers given complex structures such as this valid HTML where it isn't always going to be programatically obvious what the largest marker number value will be: