Skip to content

Switch to rendering svg icons rather than masking them - #31531

Merged
t3chguy merged 31 commits into
developfrom
t3chguy/svg-icons-dec12
Dec 15, 2025
Merged

Switch to rendering svg icons rather than masking them#31531
t3chguy merged 31 commits into
developfrom
t3chguy/svg-icons-dec12

Conversation

@t3chguy

@t3chguy t3chguy commented Dec 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This makes them visible under Contrast Control

For https://element-io.atlassian.net/browse/PSB-968

t3chguy added 26 commits December 11, 2025 13:06
@t3chguy
Switch to rendering svg icons rather than masking them in left panel
b252caf 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Remove unused stylesheet
246735e 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them for ExternalLink
0070ca0 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them for TabbedView
1c06169 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them for JoinRuleDr…
8577c9a 
…opdown

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in ManageRestr…
63cb46d 
…ictedJoinRuleDialog

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in LeaveSpaceD…
e2bf594 
…ialog

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in ReplyPreview
9737a52 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in SearchBox
62eebe7 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in RoomStatusBar
4987510 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Fix advanced.svg
276f11d 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Update snapshots
4b956a8 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Update screenshots
e4e7f17 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Iterate
0f9e076 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' into t3chguy/svg-icons-dec11
f72f7ec
@t3chguy
Fix bad merge conflict resolution
815c2c5 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in Toasts
3219117 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in RoomInfoLine
57b47ea 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in UploadBar
cfd0c36 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Remove unused class
5c80d5d 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in ConfirmSpac…
9d87cf4 
…eUserActionDialog

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in FeedbackDialog
48d3c72 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in KeyBackupFa…
5636758 
…iledDialog

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in CopyableText
49cf96e 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in EventTile
be8f919 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to rendering svg icons rather than masking them in InviteReason
785891d 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Delint
00fffe3 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Update tests
d231eb7 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Add test
02c5506 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
t3chguy marked this pull request as ready for review December 12, 2025 16:16
@t3chguy
t3chguy requested review from a team as code owners December 12, 2025 16:16
@t3chguy
t3chguy requested review from dbkr, florianduros and uhoreg and removed request for a team December 12, 2025 16:16
dbkr
dbkr approved these changes Dec 12, 2025
View reviewed changes

@dbkr dbkr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much CSS removed :D

uhoreg
uhoreg approved these changes Dec 12, 2025
View reviewed changes

@uhoreg uhoreg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a crypto standpoint, looks OK.

FYI, this will likely conflict with #31367 because it modifies code in similar places, but looks like it should be easy to resolve the conflict.

Base automatically changed from t3chguy/svg-icons-dec11 to develop December 15, 2025 10:19
@t3chguy
Add test
ccf6e83 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
t3chguy added this pull request to the merge queue Dec 15, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 15, 2025
@t3chguy
t3chguy added this pull request to the merge queue Dec 15, 2025
Merged via the queue into develop with commit 4a3cf3e Dec 15, 2025
36 checks passed
@t3chguy
t3chguy deleted the t3chguy/svg-icons-dec12 branch December 15, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbkr dbkr dbkr approved these changes
@uhoreg uhoreg uhoreg approved these changes
@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

No one assigned

Labels

T-Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t3chguy @dbkr @uhoreg