Update polls UX to match EX Mobile and improve accessibility #31245
Conversation
…e UX. - Checkmark and progress bar are only green if the poll is ended. - Updated the Poll icon for open and ended state and added labels - Right align total votes count and update text
…nto langleyd/improve-poll-ended-ux
Web doesn't show the votes for undisclosed polls(mobile does). reverting and that behaviour change should be addressed in a different PR(or on mobile.).
…nto langleyd/improve-poll-ended-ux
as we are no longer changing the copy to match mobile
langleyd
changed the title
| .map((answer) => ({ | ||
| answer, | ||
| voteCount: votes.get(answer.id) || 0, | ||
| optionNumber: poll.pollEvent.answers.findIndex((a) => a.id === answer.id) + 1, |
There was a problem hiding this comment.
The map callback gets a second arg that is the index so you don't need to make this O(n^2)
gaelledel
left a comment
gaelledel
left a comment
There was a problem hiding this comment.
So relating to https://github.com/element-hq/customer-success/issues/345 it seems we've completed removed the tag that said the poll ended? Is this what we want?
You'd need to change the icon in the composer menu too
|
On Light mode, the check mark icon is not visible for the selection
|
|
@gaelledel We have completely remove the whole poll ended event. We used to show the poll twice(without much visual different between the active and finished poll) except the second one would say "X Ended the poll". Indicating who ended the poll. Is this the one you are referring to? It is now similar to mobile in that there single poll event in the timeline now, it has a poll ended Icon, green colour progress + trophy and the disabled radio buttons to show it is finished. This UX doesn't indicate the person who ended the poll. We might be able to put that back if you think it's important(i'm not sure we care who ended it though?). The issue you are referring also detailed a bug where if one person started a poll and somebody else finished it the poll ended event would display like this with "fallback text". This doesn't happen any more. |
Fixes https://github.com/element-hq/customer-success/issues/345
Fixes https://element-io.atlassian.net/browse/PSB-929
Fixes https://element-io.atlassian.net/browse/PSB-930
What's in this PR?
Changes the text and alignment of the total votes labelWhat's dos it look like?
Old
Screen.Recording.2025-11-24.at.16.52.03.mov
New
Screen.Recording.2025-11-24.at.16.54.18.mov
Example of the new screen reader output for options: