Skip to content

Mask recovery key and passphrase input #30393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

meramsey
Copy link

@meramsey meramsey commented Jul 23, 2025

Addresses element-hq/element-meta#2888 for element web
Addresses #30174

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@meramsey meramsey requested a review from a team as a code owner July 23, 2025 20:17
@meramsey meramsey requested a review from richvdh July 23, 2025 20:17
@CLAassistant
Copy link

CLAassistant commented Jul 23, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jul 23, 2025
@t3chguy
Copy link
Member

t3chguy commented Jul 24, 2025

Not sure removing it is a solution given then it changes the design, from 2 rows down to 1 and would need design sign-off

@meramsey
Copy link
Author

I mean having columns there or not doesn't really change how it looks tbh and it matches the screen for setting it with password field

Setting recovery passphrase currently which i did not touch
Screenshot from 2025-07-24 11-08-04

How it looks with the above changes on relogin
Screenshot from 2025-07-24 11-09-23
Screenshot from 2025-07-24 11-09-42

honestly i already solved my personal problem and it was so simple i just figured i'd upstream it to be nice however you want to change it from here is fine by me.

Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested design is to add an icon that allows the user to unmask the passphrase/key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants