-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update the mobile_guide page to the new design. #30006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6914791
Rework the structure of mobile_guide.
pixlwave c2c59a6
Control the mobile_guide app variant with config.json.
pixlwave cc90764
Remove the manual instructions on the mobile_guide.
pixlwave c8031e8
Remove the back to Element link on mobile_guide
pixlwave 405f687
Finish implementing the design updates on mobile_guide.
pixlwave c634434
Split out code used on both mobile.element.io and the mobile_guide.
pixlwave e160afb
Fix some issues on the PR.
pixlwave 8f5e877
Remove unnecessary <%= require %> usages
pixlwave 992468c
Remove unused @media section.
pixlwave aafa714
Revert "Remove the back to Element link on mobile_guide"
pixlwave af5acb6
Use different copy on Step 2 for non-pro apps.
pixlwave c030f4f
Address mobile_guide PR comments:
pixlwave 4d9a666
Add missing colour tokens.
pixlwave b04c70c
Remove important block (it wasn't important 😅).
pixlwave d94d2c6
Add missing font size token (it wasn't obvious before).
pixlwave 8aaa331
Merge branch 'element-hq:develop' into doug/mobile-guide
pixlwave f84a915
Update mobile-apps.ts with the latest changes from mobile.element.io
pixlwave be4f9bc
Add screenshot tests on mobile_guide.
pixlwave 14140be
Fix accessibility errors on mobile_guide.
pixlwave b9643f5
Fix a lint error.
pixlwave 498a9f1
Merge branch 'develop' into doug/mobile-guide
t3chguy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| Copyright 2025 New Vector Ltd. | ||
|
|
||
| SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial | ||
| Please see LICENSE files in the repository root for full details. | ||
| */ | ||
|
|
||
| import { test, expect } from "../../element-web-test"; | ||
| import { MobileAppVariant } from "../../../src/vector/mobile_guide/mobile-apps"; | ||
|
|
||
| const variants = [MobileAppVariant.Classic, MobileAppVariant.X, MobileAppVariant.Pro]; | ||
|
|
||
| test.describe("Mobile Guide Screenshots", { tag: "@screenshot" }, () => { | ||
| for (const variant of variants) { | ||
| test.use({ | ||
| config: { | ||
| default_server_config: { | ||
| "m.homeserver": { | ||
| base_url: "https://matrix.server.invalid", | ||
| server_name: "server.invalid", | ||
| }, | ||
| }, | ||
| mobile_guide_app_variant: variant, | ||
| }, | ||
| viewport: { width: 390, height: 844 }, // iPhone 16e | ||
| }); | ||
| test(`should match the homepage screenshot for variant: ${variant}`, async ({ page, axe }) => { | ||
| await page.goto("/mobile_guide/"); | ||
| await expect(page).toMatchScreenshot(`mobile-guide-${variant}.png`); | ||
| await expect(axe).toHaveNoViolations(); | ||
| }); | ||
| } | ||
| }); |
Binary file added
BIN
+70.4 KB
...ight/snapshots/mobile-guide/mobile-guide.spec.ts/mobile-guide-classic-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+70.4 KB
playwright/snapshots/mobile-guide/mobile-guide.spec.ts/mobile-guide-pro-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+70.4 KB
playwright/snapshots/mobile-guide/mobile-guide.spec.ts/mobile-guide-x-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs documentation in
config.md