Skip to content

Mvvm split user info, create userinfoadmintools container component #29808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Mvvm split user info, create userinfoadmintools container component #29808

wants to merge 5 commits into from

Conversation

MarcWadai
Copy link
Collaborator

@MarcWadai MarcWadai commented Apr 24, 2025 •
edited
Loading

Part of task #29633 to mvvm right panel

Part 1 of splitting userInfo into three components :

  • UserInfoAdminToolsContainer (this PR)
  • UserInfoPowerLevel
  • UserInfoView

Changes

  • Split right_panel userinfo to use sub component UserInfoAdminToolsContainer
  • Create new component UserInfoAdminToolsContainer and corresponding VM
  • Updated userInfo-test.tsx to remove reference to userInfoAdminToolsContainer components
  • Create userInfoAdminToolsContainerViewModel-test et userInfoAdminToolsContainer-test

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Apr 24, 2025
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 81049ba to 324a280 Compare May 7, 2025 16:43
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 324a280 to 1b12b04 Compare May 7, 2025 16:55
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 1b12b04 to 92da358 Compare May 7, 2025 17:01
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 92da358 to 2d0440a Compare May 7, 2025 17:04
@MarcWadai MarcWadai marked this pull request as ready for review May 7, 2025 17:06
@MarcWadai MarcWadai requested a review from a team as a code owner May 7, 2025 17:06
@MarcWadai MarcWadai requested review from t3chguy and MidhunSureshR May 7, 2025 17:06
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 2d0440a to 306cc02 Compare May 7, 2025 17:08
@MidhunSureshR MidhunSureshR added the T-Task Tasks for the team like planning label May 14, 2025
MidhunSureshR
MidhunSureshR requested changes May 14, 2025
View reviewed changes
Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just needs some minor tweaks 👍

@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 306cc02 to 584d133 Compare May 15, 2025 17:38
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 584d133 to 123f503 Compare May 15, 2025 18:16
@MarcWadai MarcWadai requested a review from MidhunSureshR May 15, 2025 18:16
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 123f503 to 945f066 Compare May 22, 2025 09:29
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 945f066 to 9b905c7 Compare May 22, 2025 09:30
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 9b905c7 to 1bdb3c1 Compare May 22, 2025 09:38
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from a877236 to 6168729 Compare May 22, 2025 13:57
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 6168729 to d746516 Compare May 22, 2025 14:06
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 71ba9a9 to 76e64ba Compare May 22, 2025 15:56
@MarcWadai MarcWadai force-pushed the 29633-mvvm-userinfo-admin-tools-container branch from 76e64ba to ffd0162 Compare May 26, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcWadai @MidhunSureshR