Use master of js-sdk when running CI on master - #29596
Closed
dbkr wants to merge 1 commit into
Closed
Conversation
We previously checked out develop js-sdk even when building / testing mster. This would have worked usually, except when we have non-backwards compat changes on the js-sdk which we sometimes do with unstable interfaces (like sliding sync). This changes to use the master branch.
t3chguy
reviewed
Mar 26, 2025
t3chguy
left a comment
t3chguy
left a comment
Member
There was a problem hiding this comment.
What about staging? Wouldn't the existing branch matching work here? Feels like something fetchdep should just handle in the branch matching IMO
4 tasks
Member
Author
|
True, looks like we do have env vars that fetchdep can look at directly: have done that in a separate PR: #29601 |
Member
Author
|
We went with #29601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously checked out develop js-sdk even when building / testing mster. This would have worked usually, except when we have non-backwards compat changes on the js-sdk which we sometimes do with unstable interfaces (like sliding sync).
This changes to use the master branch.
Checklist
public/exportedsymbols have accurate TSDoc documentation.