Cease uploading develop.tar.gz to Github Pages #23753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Nov 11, 2022
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
should we leave this in place for a few days/weeks to give everyone a change to fetch the latest version?
Member
Author
|
Arguably no, it makes all git operations slower due to the large tarball |
Member
|
ok I think I need to understand where fetch-package.js is used. I would read the comments in that file to find out, but, well... |
Member
|
Oh I see, it's https://github.com/vector-im/element-desktop/blob/develop/package.json#L19 ok, sgtm then |
richvdh
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/element-desktop#450
The branch can then also be cleaned up
This change is marked as an internal change (Task), so will not be included in the changelog.