Update SdkConfig usage to use new translation layer + update config.md docs - #21429
Merged
Conversation
turt2live
changed the title
turt2live
force-pushed
the
travis/sssssssnake_case_config
branch
from
March 16, 2022 03:27
bff629f to
7c32edd
Compare
turt2live
marked this pull request as ready for review
March 18, 2022 03:13
germain-gg
approved these changes
Mar 18, 2022
germain-gg
left a comment
germain-gg
left a comment
Contributor
There was a problem hiding this comment.
Few minor updates, and that should be good to go 👍
Co-authored-by: Germain <germains@element.io>
benbz
added a commit
that referenced
this pull request
Jul 17, 2023
As of matrix-org/matrix-react-sdk#8062 / #21429 this should have been snake case rather than camelCase
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partnered with matrix-org/matrix-react-sdk#8062
Review with matrix-org/matrix-react-sdk#8062
Note: I went completely overboard and decided to rewrite most of the config.md documentation - it was getting annoying to edit, and had missing options. The detail that was previously there should have been maintained.
This change is marked as an internal change (Task), so will not be included in the changelog.