Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowOverridingNativeContextMenus() #17777

Merged
merged 20 commits into from
Mar 3, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jun 25, 2021

Requires: matrix-org/matrix-react-sdk#5672

element-web notes: none


This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner marked this pull request as ready for review June 30, 2021 16:11
@t3chguy t3chguy requested a review from a team June 30, 2021 16:35
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner added T-Task Tasks for the team like planning and removed T-Enhancement labels Oct 17, 2021
@andybalaam
Copy link
Contributor

This requires matrix-org/matrix-react-sdk#5672 but that one requires this.

Is there a safe order to merge these?

@SimonBrandner
Copy link
Contributor Author

This requires matrix-org/matrix-react-sdk#5672 but that one requires this.

Is there a safe order to merge these?

No, the only way is to press both buttons at the same time :P

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "half" looks sane!

@t3chguy
Copy link
Member

t3chguy commented Mar 3, 2022

Requires: matrix-org/matrix-react-sdk#5672

No longer the case, required bits landed as part of matrix-org/matrix-react-sdk#7850 also

@t3chguy t3chguy merged commit 4919992 into element-hq:develop Mar 3, 2022
@SimonBrandner SimonBrandner deleted the right-click branch March 3, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants