Skip to content

Use history replaceState instead of redirect for SSO flow #16292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3chguy merged 1 commit into from
Jan 29, 2021
Merged

Use history replaceState instead of redirect for SSO flow #16292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vector/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ function onTokenLoginCompleted() {
parsedUrl.search = "";
Copy link
Contributor

@bekliev bekliev Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to just clean particular query param?
In our case it's the loginToken

const formatted = url.format(parsedUrl);
console.log(`Redirecting to ${formatted} to drop loginToken from queryparams`);
window.location.href = formatted;
window.history.replaceState(null, "", formatted);
}

export async function loadApp(fragParams: {}) {
Expand Down