added katex.min.css to webpack for math support (main PR in matrix-react-sdk) - #15277
Merged
Conversation
jryans
requested review from
a team and
jryans
and removed request for
a team
November 24, 2020 16:00
jryans
requested changes
Nov 24, 2020
jryans
left a comment
jryans
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this generally looks reasonable!
Sorry for the tiny nits... 😅 Depending on what you decide to do with including / removing the word "math[s]" in the main PR's settings label, please adjust these strings to do the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include katex.min.css in the bundle for LaTeX math support. This goes with PR matrix-org/matrix-react-sdk#5244.