Email invites don't work #9816
Comments
|
This broke in 1.1.0 as part of matrix-org/matrix-react-sdk#2925 The old version had this: I'm taking it off my list, but leaving it as a fire for someone to fix. Given the age of the bug, I'm inclined to throw this into the "needs-design" bucket but have it fixed for the release after this week's (~2 weeks from now). |
|
I've just gone through and tested all the different possible scenarios here. Here are the results. Bugs identified marked with [!!]: not signed in, signup w/o email
not signed in, signup with invited email
not signed in, signup with different email
not signed in, sign in with account that has invited email (invite sent before email bound)
not signed in, sign in with account that doesn't have invited email
signed in with account that has invited email
signed in with account that doesn't have invited email
|
|
Still there in Riot-web 1.2.1 (RiotSDK 1.2.1) even though RiotSDK 1.1.1 'fixes' email registration. |
|
It's definitely known this is still an issue. It's being worked on. |
|
I got all exicited when I saw the 'fixed' comment in 1.1.1 |
|
Yep, email registration and email invites are different things. |
|
Another bug: if the HS has guest access disabled when you click on the email invite link, it just redirects to the welcome screen when it fails to register a guest user. |
Riot was always saying the email address that the invite was sent
to was not associated with your account.
Two fixes here:
1. We mounted RoomPreviewBar with no invitedEmail prop and then
changed the prop later, but RoomPreviewBar only checked for it
on mount. Make sure we re-check when the props change.
2. Pass oobData through RoomPreviewBar because we need to pass it
to the RoomAvatar for 3pid invites.
element-hq/element-web#9816
When the user was on an invite page and clicked the sign up/sign in buttons, remember that invite so we can show it again after they're done signing up/in. element-hq/element-web#9816
This affects /app as of writing.
The user clicks the link and is presented with a dialog-looking thing to create an account. They click this and are brought to the normal registration page. If the user happens to be logged in to an account already, they are just directed to the room rather than being told to verify their email address.
Not sure when this broke exactly, but it's not good.
Checkboxes for bugs identified here:
if the HS has guest access disabled when you click on the email invite link, it just redirects to the welcome screen when it fails to register a guest user.Split out to Email invites land on welcome page with guest disabled #10026The text was updated successfully, but these errors were encountered: