Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbing through autocomplete doesn't work anymore #7059

Closed
turt2live opened this issue Jul 18, 2018 · 3 comments
Closed

Tabbing through autocomplete doesn't work anymore #7059

turt2live opened this issue Jul 18, 2018 · 3 comments
Labels
A-Pills P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker

Comments

@turt2live
Copy link
Member

on /develop, chrome windows 10.

  1. Start typing an alias with multiple results
  2. Press tab twice, having your eye on the last option
  3. Autocomplete disappears with the second option picked for you

I should be able to get to the 3rd and 4th suggestion.
@t3chguy
Copy link
Member

t3chguy commented Jul 18, 2018

Argh this is caused by the "hide if focus changes" :(

@t3chguy
Copy link
Member

t3chguy commented Jul 18, 2018

oh argh, Pills in the composer don't count as "text" so when it switches between pills the condition fails because "text ' ' === text ' '" :(

t3chguy added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 18, 2018
@t3chguy
replace heuristic for the time being as it failed with inlines like p…
855f887 
…ills. Fixes element-hq/element-web#7059

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker type:composer labels Jul 19, 2018
@t3chguy
Copy link
Member

t3chguy commented Jul 20, 2018

this got fixed

@t3chguy t3chguy closed this as completed Jul 20, 2018
@jryans jryans added the A-Pills label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Pills P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @turt2live @lampholder @t3chguy