Invite suggestions are unreliable

[pafcu]

Description

When you invite a person to a room and start typing a Matrix ID you get suggestions. However, as you type, sometimes valid suggestions are removed.

Steps to reproduce

• Create a room
• Press Invite to this room
• Write @riot-bot:matrix (note that it suggests @riot-bot:matrix.org)
• Write @riot-bot:matrix.o (note that it no longer suggests @riot-bot:matrix.org)

Version information

Riot web c28d9e5-react-c002d3ff9967-js-36ff0ad0193e on FF57

[lampholder]

It's good to see this behaviour spelled out - I've experienced it (and felt it feeling clunky) but it's helpful to see it clearly articulated.

I wonder what we should do instead.

Potentially:

• All the while there's an exact partial match with a known mxid we should probably keep that as the highlighted option.
• If there is no matching known mxid then suggesting the partially completed mxid is probably fine (though only accepting a 'complete' mxid might be better - why am I allowed to invite the obviously-invalid @riot-bot:matrix?)

'Completeness' risks being hard to define (is @riot-bot:matrix.com complete? If so what about @riot-bot:matrix.co?) I guess if we only converted inputs matching @\w+:\w+\.(any|valid|tld) into a suggestion we'd be okay?

[pafcu]

What is more confusing to me is why a valid suggestion is removed in the first place? (i.e. @riot-bot:matrix.org is a perfectly valid suggestion after typing @riot-bot:matrix.o, yet it is suddenly no longer offered as an alternative). I can live with some clearly incorrect alternatives being shown, or even highlighted, but please don't remove the correct ones! :-)

Also, the avatar for the suggested "incomplete" mxid annoyingly changes color while you type.

[aaronraimist]

This seems to be fixed in the new invite dialog

[turt2live]

Yea, if it's still a problem please open a new issue.