Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better defaults for emoji (plaintext) auto completion #4554

Closed
kethinov opened this issue Jul 10, 2017 · 18 comments
Closed

Better defaults for emoji (plaintext) auto completion #4554

kethinov opened this issue Jul 10, 2017 · 18 comments

Comments

@kethinov
Copy link

Offshoot of this discussion: #2567 (comment)

This would be a good guide to follow: https://aprescott.com/posts/hangouts-emoji

@turt2live
Copy link
Member

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 11, 2017

"Better" is quite subjective and I'm still not clear on what you mean. We currently use the meta data from the emojione data set:
:') :'-) :D :-D =D ':) ':-) '=) ':D ':-D '=D >:) >;) >:-) >=) O:-) 0:-3 0:3 0:-) 0:) 0;^) O:) O;-) O=) 0;-) O:-3 O:3 ;) ;-) *-) *) ;-] ;] ;D ;^) :) :-) =] =) :] :* :-* =* :^* >:P X-P x-p :P :-P =P :-p :p =p :-Þ :Þ :þ :-þ :-b :b d: B-) B) 8) 8-) B-D 8-D :-X :X :-# :# =X =x :x :-x =# -_- -__- -___- :$ =$ >:[ :-( :( :-[ :[ =( >:( >:-( :@ >:\ >:/ :-/ :-. :/ :\ =/ =\ :L =L >.< :-O :O :-o :o O_O >:O D: :'( :'-( ;( ;-( ':( ':-( '=( #-) #) %-) %) X) X-) *\0/* \0/ *\O/* \O/ <3 </3

or in unicode:
😂😃😅😆😇😉🙂😘😜😛😎😶😑😳😞😠😕😣😮😨😢😓😵🙆❤💔

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 13, 2017

@kethinov By "better", do you mean "include the Hangouts emoji shortcuts too"?

Emojione doesn't currently have a mechanism for custom shortcuts but we can add them at runtime via user settings.

(Also, looks like RocketChat is having the same problem 😜 joypixels/emojione#411)

lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 13, 2017
…xt emojis

FTR a list of plaintexts and their unicode equivalents can be found here - element-hq/element-web#4554 (comment)

Pressing space after a matching emoji will replace the plaintext emoji with the equivalent unicode emoji.
@lukebarnard1
Copy link
Contributor

I think we should also consider whether using the above replacements is going to get confusing WRT the auto-completions, which show a different ordering of emoji.

e.g. ":L" produces
2017-07-13-175500_662x369_scrot

but will auto replace to the emojione interpretation of ":L", which is 😕

@lukebarnard1 lukebarnard1 changed the title Better defaults for emoji auto completion Better defaults for emoji (plaintext) auto completion Jul 13, 2017
@kethinov
Copy link
Author

I think what Mattermost does would be a good model.

On Mattermost you have both ASCII-style shortcuts, e.g. :) or :p auto replacing into 😀 and 😛 as well as an auto completion interface like :stuck_out_tongue: with a picker similar to Riot's.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 14, 2017

On Mattermost you have both ASCII-style shortcuts, e.g. :) or :p auto replacing into 😀 and 😛 as well as an auto completion interface like :stuck_out_tongue: with a picker similar to Riot's.

this is exactly what Riot does (albeit you have to tick a box in user settings to enabled auto replacement). But I thought you were more concerned about the particular plaintexts chosen?

@kethinov
Copy link
Author

On a second look, yeah, there may be nothing to do here. I'm basing this mostly on your comment about replacement string priorities here. I forgot the checkbox was already implemented because it isn't in 0.11.4, so I haven't yet played with the feature.

@lukebarnard1
Copy link
Contributor

@kethinov OK, fair enough and thanks for clarifying. Let's keep this issue open as I'm sure others will have thoughts on this.

@kethinov
Copy link
Author

Just tested this with the latest update. Checkbox "Automatically replace plain text Emoji" is checked and it doesn't appear to do any auto replacing. (Riot 0.12.1)

@lukebarnard1
Copy link
Contributor

@kethinov you'll have to be a bit more specific. What were the steps to reproduce, what did you expect etc.

@kethinov
Copy link
Author

kethinov commented Aug 24, 2017

Riot 0.12.2, ASCII-style shortcuts, e.g. :) or :p auto replacing into 😀 and 😛 do not work with the "Automatically replace plain text Emoji" checkbox checked.

The auto complete method using : to bring up the emoji picker menu does work.

@t3chguy
Copy link
Member

t3chguy commented Aug 24, 2017

@kethinov the catch is you have to hit space after :P to complete it

@t3chguy
Copy link
Member

t3chguy commented Aug 24, 2017

or even with the option off you can do :P [TAB]

@kethinov
Copy link
Author

Ah there we go. Woohoo! 🎉

@t3chguy
Copy link
Member

t3chguy commented Aug 24, 2017

@kethinov there is a related issue you may be interested in: #4872

@xoxys
Copy link

xoxys commented Jan 21, 2019

Why this not work on android?

@jryans
Copy link
Collaborator

jryans commented Jan 21, 2019

Why this not work on android?

This is the repo for Riot Web. You can file Riot Android issues in that repo.

@xoxys
Copy link

xoxys commented Jan 21, 2019

My fault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants