Big modal dialogs randomly scroll to the bottom when loaded

[ara4n]

i think this is because the dialog starts off with tiny vertical height, and then expands after the component is loaded, leaving the scroll offset very confused

[richvdh]

If this is referring to the EncryptedEventDialog, it's nothing to do with the asyncness of it - it's because the OK button is autoFocus: true, which makes it scroll into view.

[richvdh]

presumably the right fix to that is to collect "enter" keypresses in the dialog rather than autofocussing the button. In general we probably want to factor the escape/enter handling out of all the dialog impls.

Matthew: can you confirm if this was the bug you meant, or if I have misunderstood?

[ara4n]

yup, this would be the bug - i hadn't spotted the autoFocus: true. However, i think a better solution would be not to scroll the buttons off the bottom of the dialog, which is horrific UX, but instead chuck a gemini scrollbar on the body of the dialog if it insists on being too large.

[richvdh]

Not obvious to me that losing the top of the dialog is much better than losing the bottom, but ok

[ara4n]

I'm not suggesting losing the bottom of the dialog, only its body. I'm suggesting you show the body, scrolled to top as per any sane windowing system, given humans read information top-to-bottom. But the buttons are always visible on the bottom.

[richvdh]

ah, sorry, missed that.

[richvdh]

The mechanics of adding a geminiscrollbar to the dialog are trivial.

The CSS-fu to make the dialog fill just the right amount of the screen, however, appears to be beyond me. I spent a while messing about with flex layouts and nothing seemed to work. Hope @ara4n can help!