Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"migrating_crypto" translation should use "%(brand)s" instead of "Element" #27021

Closed
estellecomment opened this issue Feb 16, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12265
Closed

"migrating_crypto" translation should use "%(brand)s" instead of "Element" #27021

estellecomment opened this issue Feb 16, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12265
Assignees
@richvdh
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust I18n O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@estellecomment
Copy link

Steps to reproduce

(sorry if I should be doing this in localazy : I couldn't find where. Maybe I don't have access for that task.)

  1. Where are you starting? What can you see?
    In localazy, translation for "migrating_crypto" in english is : "Hang tight. We are updating Element to make encryption faster and more reliable."
    https://localazy.com/p/element-web/phrases/521/edit/_a7510213276586093000

Outcome

What did you expect?

"Hang tight. We are updating %(brand)s to make encryption faster and more reliable."

What happened instead?

Element, not %(brand)s

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@richvdh
Copy link
Member

richvdh commented Feb 16, 2024

cf matrix-org/matrix-react-sdk#12104

@florianduros florianduros added S-Minor Impairs non-critical functionality or suitable workarounds exist I18n O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Feb 19, 2024
@richvdh richvdh self-assigned this Feb 20, 2024
richvdh added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 20, 2024
@richvdh
Fix branding in "migrating crypto" message
be2c1f3 
Fixes element-hq/element-web#27021
@richvdh richvdh mentioned this issue Feb 20, 2024
Merged
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 20, 2024
@richvdh
Fix branding in "migrating crypto" message (#12265)
3714057 
Fixes element-hq/element-web#27021
@richvdh richvdh mentioned this issue Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust I18n O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix branding in "migrating crypto" message matrix-org/matrix-react-sdk
3 participants
@estellecomment @richvdh @florianduros