Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room avatars are not properly visible in search dialogue #26133

Closed
bbhtt opened this issue Sep 7, 2023 · 5 comments · Fixed by matrix-org/matrix-react-sdk#11580
Closed

Room avatars are not properly visible in search dialogue #26133

bbhtt opened this issue Sep 7, 2023 · 5 comments · Fixed by matrix-org/matrix-react-sdk#11580
Assignees
@t3chguy
Labels
A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@bbhtt
Copy link

bbhtt commented Sep 7, 2023

Steps to reproduce

  1. Open the public room search dialogue
  2. See that the room logos are cut off

On Develop:

image

On stable:

image

Outcome

What did you expect?

They should be properly visible

What happened instead?

Not properly visible

Operating system

Fedora 39

Browser information

firefox 119.0a1 (2023-09-05)

URL for webapp

https://develop.element.io/

Application version

Element version: 54fd7a9-react-c825e34f16fa-js-6c307d4c63e3 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

No
@bbhtt bbhtt added the T-Defect label Sep 7, 2023
@Nivas7
Copy link

Nivas7 commented Sep 7, 2023 •
edited
Loading

Could you please assign me the [#26133/Set Room Logos Visible]?

Think I can fix this issue.

@weeman1337 weeman1337 added X-Regression A-Avatar S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 7, 2023
@weeman1337
Copy link
Contributor

Could you please assign me the [#26133/Set Room Logos Visible]?

Think I can fix this issue.

Thank you for your interest in this issue. We will normally not assign the issue to an external contributor until they have provided at least a draft PR which is taking the right direction. For further details, see our guidance on assigning issues.

If you have any technical questions about this issue, you can ask for help in #element-dev:matrix.org

@t3chguy
Copy link
Member

t3chguy commented Sep 7, 2023

Affects staging

@weeman1337
Copy link
Contributor

Regressed by matrix-org/matrix-react-sdk@09c5e06

@kittykat kittykat changed the title Room logos are not properly visible in search dialogue Room avatars are not properly visible in search dialogue Sep 7, 2023
@t3chguy
Copy link
Member

t3chguy commented Sep 7, 2023

@Nivas7 thanks for your interest here, unfortunately due to it being a release blocker we'll be taking it on just to get it done swiftly.

@t3chguy t3chguy self-assigned this Sep 7, 2023
@t3chguy t3chguy mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Avatar O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix avatars in public room & space search being flex shrunk matrix-org/matrix-react-sdk
4 participants
@t3chguy @weeman1337 @bbhtt @Nivas7