Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intentional Mentions testing: Pings for display name and MXID text shouldn't happen #25497

Closed
daniellekirkwood opened this issue Jun 1, 2023 · 0 comments · Fixed by matrix-org/matrix-js-sdk#3445
Closed

Intentional Mentions testing: Pings for display name and MXID text shouldn't happen #25497

daniellekirkwood opened this issue Jun 1, 2023 · 0 comments · Fixed by matrix-org/matrix-js-sdk#3445
Assignees
@kerryarchibald
Labels
A-Notifications O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-GetYourUpdates Z-Labs

Comments

@daniellekirkwood
Copy link
Contributor

Steps to reproduce

During the testing session for the MSC we found that using a users displayname or their MXID sends a red highlight ping in encrypted rooms and it should not. In unencrypted rooms the ping acts as expected but the text still turns red, the two are likely related and indicate a client side issue

To repro:

  • Have 2 accounts with intentional mentions labs flag on (ask @clokep or @daniellekirkwood if needed)
  • Send a message containing the display name of the other account to an encrypted room
  • The message should not ping as the user has not sent a pill, just plain text that matches the display name.

EG: "Danielle" or "daniellekirkwood:matrix.org" written this way in the composer should not send a red highlight ping. Only a pillifed tag should send a red highlight ping

Outcome

What did you expect?

What happened instead?

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

Yes
@weeman1337 weeman1337 added Z-Labs S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 2, 2023
This was referenced Jun 6, 2023
Merged
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 22, 2024
@su-ex
Merge tag 'v26.1.0' into sc
10fe11f 
* Introduce a new `Crypto.Verifier` interface, and deprecate direct access to `VerificationBase`, `SAS` and `ReciprocateQRCode` ([\matrix-org#3414](matrix-org#3414)).
* Add `rust-crypto#isCrossSigningReady` implementation ([\matrix-org#3462](matrix-org#3462)). Contributed by @florianduros.
* OIDC: Validate `m.authentication` configuration ([\matrix-org#3419](matrix-org#3419)). Contributed by @kerryarchibald.
* ElementR: Add `CryptoApi.getCrossSigningStatus` ([\matrix-org#3452](matrix-org#3452)). Contributed by @florianduros.
* Extend stats summary with call device and user count based on room state ([\matrix-org#3424](matrix-org#3424)). Contributed by @toger5.
* Update MSC3912 implementation to use `with_rel_type` instead of `with_relations` ([\matrix-org#3420](matrix-org#3420)).
* Export thread-related types from SDK ([\matrix-org#3447](matrix-org#3447)). Contributed by @stas-demydiuk.
* Use correct /v3 prefix for /refresh ([\matrix-org#3016](matrix-org#3016)). Contributed by @davidisaaclee.
* Fix thread list being ordered based on all updates ([\matrix-org#3458](matrix-org#3458)). Fixes element-hq/element-web#25522.
* Fix: handle `baseUrl` with trailing slash in `fetch.getUrl` ([\matrix-org#3455](matrix-org#3455)). Fixes element-hq/element-web#25526. Contributed by @kerryarchibald.
* use cli.canSupport to determine intentional mentions support ([\matrix-org#3445](matrix-org#3445)). Fixes element-hq/element-web#25497. Contributed by @kerryarchibald.
* Make sliding sync linearize processing of sync requests ([\matrix-org#3442](matrix-org#3442)).
* Fix edge cases around 2nd order relations and threads ([\matrix-org#3437](matrix-org#3437)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerryarchibald kerryarchibald

Labels
A-Notifications O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-GetYourUpdates Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use cli.canSupport to determine intentional mentions support matrix-org/matrix-js-sdk
3 participants
@kerryarchibald @weeman1337 @daniellekirkwood