Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to stop sending read receipts to other users #2527

Closed
richvdh opened this issue Nov 1, 2016 · 31 comments · Fixed by matrix-org/matrix-react-sdk#3395 or matrix-org/matrix-react-sdk#8629

Comments

@richvdh
Copy link
Member

richvdh commented Nov 1, 2016

For bonus points, configurable per room. cf: #2526

@richvdh
Copy link
Member Author

richvdh commented Nov 1, 2016

cf also #395

@richvdh richvdh closed this as completed Nov 1, 2016
@richvdh richvdh reopened this Nov 1, 2016
@richvdh richvdh changed the title option to stop sending RRs to other users option to stop sending read receipts to other users Nov 1, 2016
@ara4n ara4n mentioned this issue Nov 1, 2016
18 tasks
@ara4n ara4n changed the title option to stop sending read receipts to other users Option to stop sending read receipts to other users Nov 6, 2016
@jooize
Copy link

jooize commented Mar 10, 2017

Can someone point me to where I disable read receipts in the code of riot-web until there's a proper UI setting for it?

@ara4n
Copy link
Member

ara4n commented Mar 11, 2017

Sure - the bluntest way to do it would be to have sendReadReceipt at https://github.com/matrix-org/matrix-react-sdk/blob/master/src/components/structures/TimelinePanel.js#L464 immediately return.

@ara4n ara4n added the easy label Mar 11, 2017
@turt2live
Copy link
Member

turt2live commented Apr 21, 2017

Doing that recommendation ends up leaving some wonderfully stuck notifications. Is that an acceptable side effect? or is some other approach desirable for the checkbox?

Ftr: this is the commit that I ended up implementing, which has the potentially-buggy behaviour: turt2live/matrix-react-sdk@1bdae49

turt2live added a commit to turt2live/matrix-react-sdk that referenced this issue Apr 21, 2017
Addresses element-hq/element-web#2527.

The side effect of this is that notifications remain stuck. Because the RR isn't sent, the unread notification stays on the client. This also ends up affecting riot-android, and likely riot-ios.

Signed-off-by: Travis Ralston <travpc@gmail.com>
@ara4n
Copy link
Member

ara4n commented Apr 22, 2017

This is fine - i've filed the element-hq/riot-android#1151 to sort out the stuck notif problem. This doesn't exist on riot-ios as opening the app clears notifs anyway. Thanks for doing this!!

@ara4n ara4n closed this as completed Apr 22, 2017
@ara4n
Copy link
Member

ara4n commented Apr 22, 2017

reopening until this is PR'd :)

@turt2live
Copy link
Member

@ara4n - PR opened: matrix-org/matrix-react-sdk#821

The stuck notifications are also a problem in riot-web.
image

@ara4n
Copy link
Member

ara4n commented Apr 22, 2017

oh, crap.

@turt2live
Copy link
Member

I did only test against Synapse 0.20, however. It may be fixed with a homeserver with proper read marker support?

@ara4n
Copy link
Member

ara4n commented Apr 22, 2017

nope, the new RM support doesn't fix this problem - it will need a spec addition. Have filed element-hq/riot-meta#66 to track it; the PR will have to wait :(

@ara4n ara4n removed the easy label May 15, 2017
turt2live added a commit to turt2live/matrix-react-sdk that referenced this issue Jun 1, 2017
Addresses element-hq/element-web#2527.

The side effect of this is that notifications remain stuck. Because the RR isn't sent, the unread notification stays on the client. This also ends up affecting riot-android, and likely riot-ios.

Signed-off-by: Travis Ralston <travpc@gmail.com>
@ara4n
Copy link
Member

ara4n commented Sep 10, 2019

wdyt about giving the server a way to enforce it rather than it being a client thing?

@turt2live
Copy link
Member

Could theoretically be handled as some special account data event (yay) - the server could refuse to let the user edit it, and it could enforce it if the client forgets to send a hidden RR. I'd still want to support the m.hidden flag on the RR though so that clients can implement a "stop sending receipts for the next few minutes" without consulting the server (or something).

@turt2live
Copy link
Member

Another thing to worry about is possibly never wanting to send read receipts to a particular server/user. It's a little unfortunate that clicking a room can alert the user to your presence despite you not wanting them to know about you.

@anon88391
Copy link

It's been almost 2 years and you still haven't managed to fix the most privacy invading feature of your app. Fix your shit please.

@turt2live
Copy link
Member

@anon88391 the flag is in the app, there's a MSC to change the spec out, and the synapse PR has minor work to be done on it.

Please read the comments before getting angry about something.

@erciccione
Copy link

Any update about this? This issue is now more than 3 years old, but this feature is vey needed.

@tredondo
Copy link

Where can I find and toggle the flag in the app/labs?

@t3chguy
Copy link
Member

t3chguy commented Apr 20, 2020

image

In Labs which require special config.json options per the docs like on riot.im/develop . But as the title says, it needs a compatible homeserver otherwise all your rooms will always be flagged as unread.

@mcg-matrix
Copy link

For bonus points, configurable per room. cf: #2526

That doesn't seem to match:

  1. This issue here (Option to stop sending read receipts to other users #2527) is a privacy issue about not sending read receipts, i.e. not making the information available to others; issue Option to disable showing RRs #2526 is about not displaying available information ("read receipt markers" or "read avatars" or whatever exactly they are called; option "Show read receipts sent by other users").
  2. Option to disable showing RRs #2526 is closed, but it did not lead to a config setting per room, AFAICS.

Personally, I'd like to have a per-room option of not sending read receipts, #14030.

@t3chguy
Copy link
Member

t3chguy commented Jun 14, 2020

For bonus points, configurable per room. and cf: #2526
are two separate statements. They are unrelated.

@dnut
Copy link

dnut commented Jul 19, 2020

it needs a compatible homeserver

Are there any compatible homeservers? Synapse does not support this yet. matrix-org/synapse#5990 matrix-org/matrix-spec-proposals#2285

otherwise all your rooms will always be flagged as unread.

This is not my experience. The read receipts are still being sent as if they are enabled. I wouldn't even mind everything being flagged as unread. I just really need to not send read receipts.

@turt2live
Copy link
Member

ftr the option has been removed from labs because there's no such thing as a compatible homeserver. This is blocked on the notifications rework to decouple read receipts from push.

@integratedfactor8
Copy link

This issue has been open for approximately 4.17 years -- which suggests it is quite a difficult issue to resolve, and makes it difficult to make a judgement on how long this would take to properly resolve. I believe this is a significant issue for users who do not wish for unnecessary information of their actions of reading messages to be visible to others. In order to resolve this issue swiftly until further functionality is implemented to allow for a better solution, there could be a temporary, experimental option which would stop read receipts being sent by disabling any Internet communications of messages being read, despite the problems of messages not being properly marked as read for the user. Such an option could be located under the Labs category of settings, and there could be a warning that messages will not be properly marked as read while this option is set to disable communication of reading messages. I believe some may prefer keeping their actions private than messages being marked as read from all clients, so this would be a wonderful option for such individuals, until a better implementation can be achieved.

@escapewindow
Copy link

If we're going stopgap, and if they're comparable in terms of effort, I'd prefer if we turn off sending any read receipts to anyone else, until it can be implemented in a privacy-maintaining way. E.g., user X's client will send a read receipt to the server, but the server doesn't notify any other users that user X has read the messages.

@turt2live
Copy link
Member

@integratedfactor8 Breaking notifications (and unread counts) for people is more likely to increase our support load, even for a labs feature - we're more inclined to fix it properly as mentioned above several times.

@escapewindow per above, this would break notifications and unread counts.

I'm locking this as the conversation is going in circles.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.