Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"via" parameter in room URL gives other result when I try to join #24617

Closed
JeanPaulLucien opened this issue Feb 22, 2023 · 9 comments
Closed

Comments

@JeanPaulLucien
Copy link

JeanPaulLucien commented Feb 22, 2023

Here is Help vampire again. I have discovered the reason of special case of "Failed to join" popup.

Steps to reproduce

https://matrix.to/#/!elPHPEplkxTcHJLIRR:feneas.org?via=feneas.org 
https://matrix.to/#/!tUpugqyPScyTwHoucv:feneas.org?via=feneas.org

https://matrix.to/#/!elPHPEplkxTcHJLIRR:feneas.org 
https://matrix.to/#/!tUpugqyPScyTwHoucv:feneas.org

Note: server does not exist. 2 rooms above. 1 = 3, 2 = 4.

  1. Try to join to room using any link in 1st group.
  2. Join to room using any link in 2nd group.
  3. You got the different text in popup.

Outcome

What did you expect?

Same result for both group. Normal description why I can't join for 1st group. For 2nd group it's 404 (I suppose it's normal description).

What happened instead?

Different result between 1st and 2nd group of link. Just "Failed to join" for 1st group.

Operating system

Windows

Application version

1.11.23

How did you install the app?

In-app update

Homeserver

matrix.org

Will you send logs?

No

@JeanPaulLucien JeanPaulLucien changed the title ?via= in room link gives other result when I try to join "via" parameter in room link gives other result when I try to join Feb 22, 2023
@JeanPaulLucien
Copy link
Author

It's discovered case of #24162

@JeanPaulLucien JeanPaulLucien changed the title "via" parameter in room link gives other result when I try to join "via" parameter in room URL gives other result when I try to join Feb 23, 2023
@t3chguy
Copy link
Member

t3chguy commented Feb 23, 2023

Duplicate of #13247

@t3chguy t3chguy marked this as a duplicate of #13247 Feb 23, 2023
@t3chguy t3chguy closed this as completed Feb 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
@JeanPaulLucien
Copy link
Author

@t3chguy in my case you know that server of room does not exist more; it seems the link without "via" provides the correct information why I can't join. You could to make the fix for my case and possible other issue will be resolved too. It could be the reference.

@t3chguy I have seen the pool request. It's totally different and will not resolve this issue.

@t3chguy
Copy link
Member

t3chguy commented Feb 23, 2023

@JeanPaulLucien the server doesn't tell us that the other server doesn't exist anymore. Just that the join failed.

@JeanPaulLucien
Copy link
Author

@t3chguy the links from 2nd group gives the popup with normal information. I suppose that same popup should be when I try to join using links from 1st group.

@JeanPaulLucien
Copy link
Author

JeanPaulLucien commented Feb 23, 2023

Okay, 2nd group:
image
Why other text in popup? Not okay, 1st group:
image

Just discover why Element can't give same popup for same room.

@t3chguy
Copy link
Member

t3chguy commented Feb 23, 2023

Because the server itself gives a different error. I suggest Settings > Help & About > Submit debug logs > Download logs so you can see for yourself

@JeanPaulLucien
Copy link
Author

1st group. 403 when I click on the link, 502 when click Join to...

fetch.ts:62          GET https://matrix-client.matrix.org/_matrix/client/r0/rooms/!elPHPEplkxTcHJLIRR%3Afeneas.org/initialSync?limit=20 403
fetch @ fetch.ts:62
requestOtherUrl @ fetch.ts:264
request @ fetch.ts:205
authedRequest @ fetch.ts:156
roomInitialSync @ client.ts:7932
peek @ sync.ts:410
peekInRoom @ client.ts:6177
setupRoom @ RoomView.tsx:784
(anonymous) @ RoomView.tsx:706
componentDidMount @ RoomView.tsx:842
_s @ react-dom.production.min.js:219
Rl @ react-dom.production.min.js:259
t.unstable_runWithPriority @ scheduler.production.min.js:18
$i @ react-dom.production.min.js:122
Il @ react-dom.production.min.js:252
vl @ react-dom.production.min.js:243
(anonymous) @ react-dom.production.min.js:123
t.unstable_runWithPriority @ scheduler.production.min.js:18
$i @ react-dom.production.min.js:122
Yi @ react-dom.production.min.js:123
Wi @ react-dom.production.min.js:122
ml @ react-dom.production.min.js:237
enqueueSetState @ react-dom.production.min.js:133
f.setState @ react.production.min.js:12
setState @ MatrixChat.tsx:415
viewRoom @ MatrixChat.tsx:981
(anonymous) @ MatrixChat.tsx:698
t._invokeCallback @ Dispatcher.js:214
t.dispatch @ Dispatcher.js:189
setTimeout (async)
dispatch @ dispatcher.ts:52
showScreen @ MatrixChat.tsx:1855
(anonymous) @ routing.ts:42
p @ routing.ts:50
hashchange (async)
click @ linkify-matrix.ts:165
rageshake.ts:73 !elPHPEplkxTcHJLIRR:feneas.org is current in RVS but missing from client - clearing sticky room
e.<computed> @ rageshake.ts:73
(anonymous) @ logger.ts:44
handleRVSUpdate @ RoomListStore.ts:153
(anonymous) @ RoomListStore.ts:124
s.emit @ events.js:158
setState @ RoomViewStore.tsx:226
joinRoom @ RoomViewStore.tsx:529
onDispatch @ RoomViewStore.tsx:297
t._invokeCallback @ Dispatcher.js:214
t.dispatch @ Dispatcher.js:189
setTimeout (async)
dispatch @ dispatcher.ts:52
(anonymous) @ RoomView.tsx:1467
Promise.then (async)
(anonymous) @ RoomView.tsx:1465
ze @ react-dom.production.min.js:52
Ye @ react-dom.production.min.js:52
(anonymous) @ react-dom.production.min.js:53
Dr @ react-dom.production.min.js:100
kr @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Pe @ react-dom.production.min.js:292
(anonymous) @ react-dom.production.min.js:50
Mr @ react-dom.production.min.js:105
Jt @ react-dom.production.min.js:75
Zt @ react-dom.production.min.js:74
t.unstable_runWithPriority @ scheduler.production.min.js:18
$i @ react-dom.production.min.js:122
Ne @ react-dom.production.min.js:292
Qt @ react-dom.production.min.js:73
://vector/webapp/#/room/!elPHPEplkxTcHJLIRR:feneas.org:1 Access to fetch at 'https://matrix-client.matrix.org/_matrix/client/r0/join/!elPHPEplkxTcHJLIRR%3Afeneas.org?server_name=feneas.org' from origin 'vector://vector' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
fetch.ts:62          POST https://matrix-client.matrix.org/_matrix/client/r0/join/!elPHPEplkxTcHJLIRR%3Afeneas.org?server_name=feneas.org net::ERR_FAILED 502
fetch @ fetch.ts:62
requestOtherUrl @ fetch.ts:264
request @ fetch.ts:205
authedRequest @ fetch.ts:156
joinRoom @ client.ts:3999
await in joinRoom (async)
dis.dispatch.action @ RoomViewStore.tsx:541
i @ promise.ts:39
joinRoom @ RoomViewStore.tsx:539
onDispatch @ RoomViewStore.tsx:297
t._invokeCallback @ Dispatcher.js:214
t.dispatch @ Dispatcher.js:189
setTimeout (async)
dispatch @ dispatcher.ts:52
(anonymous) @ RoomView.tsx:1467
Promise.then (async)
(anonymous) @ RoomView.tsx:1465
ze @ react-dom.production.min.js:52
Ye @ react-dom.production.min.js:52
(anonymous) @ react-dom.production.min.js:53
Dr @ react-dom.production.min.js:100
kr @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Pe @ react-dom.production.min.js:292
(anonymous) @ react-dom.production.min.js:50
Mr @ react-dom.production.min.js:105
Jt @ react-dom.production.min.js:75
Zt @ react-dom.production.min.js:74
t.unstable_runWithPriority @ scheduler.production.min.js:18
$i @ react-dom.production.min.js:122
Ne @ react-dom.production.min.js:292
Qt @ react-dom.production.min.js:73
rageshake.ts:73 !elPHPEplkxTcHJLIRR:feneas.org is current in RVS but missing from client - clearing sticky room

2nd group: 403 when I click on link and 404 when I click join to

fetch.ts:62          GET https://matrix-client.matrix.org/_matrix/client/r0/rooms/!elPHPEplkxTcHJLIRR%3Afeneas.org/initialSync?limit=20 403
fetch @ fetch.ts:62
requestOtherUrl @ fetch.ts:264
request @ fetch.ts:205
authedRequest @ fetch.ts:156
roomInitialSync @ client.ts:7932
peek @ sync.ts:410
peekInRoom @ client.ts:6177
setupRoom @ RoomView.tsx:784
(anonymous) @ RoomView.tsx:706
componentDidMount @ RoomView.tsx:842
_s @ react-dom.production.min.js:219
Rl @ react-dom.production.min.js:259
t.unstable_runWithPriority @ scheduler.production.min.js:18
$i @ react-dom.production.min.js:122
Il @ react-dom.production.min.js:252
vl @ react-dom.production.min.js:243
(anonymous) @ react-dom.production.min.js:123
t.unstable_runWithPriority @ scheduler.production.min.js:18
$i @ react-dom.production.min.js:122
Yi @ react-dom.production.min.js:123
Wi @ react-dom.production.min.js:122
ml @ react-dom.production.min.js:237
enqueueSetState @ react-dom.production.min.js:133
f.setState @ react.production.min.js:12
setState @ MatrixChat.tsx:415
viewRoom @ MatrixChat.tsx:981
(anonymous) @ MatrixChat.tsx:698
t._invokeCallback @ Dispatcher.js:214
t.dispatch @ Dispatcher.js:189
setTimeout (async)
dispatch @ dispatcher.ts:52
showScreen @ MatrixChat.tsx:1855
(anonymous) @ routing.ts:42
p @ routing.ts:50
hashchange (async)
click @ linkify-matrix.ts:165
rageshake.ts:73 !elPHPEplkxTcHJLIRR:feneas.org is current in RVS but missing from client - clearing sticky room
e.<computed> @ rageshake.ts:73
(anonymous) @ logger.ts:44
handleRVSUpdate @ RoomListStore.ts:153
(anonymous) @ RoomListStore.ts:124
s.emit @ events.js:158
setState @ RoomViewStore.tsx:226
joinRoom @ RoomViewStore.tsx:529
onDispatch @ RoomViewStore.tsx:297
t._invokeCallback @ Dispatcher.js:214
t.dispatch @ Dispatcher.js:189
setTimeout (async)
dispatch @ dispatcher.ts:52
(anonymous) @ RoomView.tsx:1467
Promise.then (async)
(anonymous) @ RoomView.tsx:1465
ze @ react-dom.production.min.js:52
Ye @ react-dom.production.min.js:52
(anonymous) @ react-dom.production.min.js:53
Dr @ react-dom.production.min.js:100
kr @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Pe @ react-dom.production.min.js:292
(anonymous) @ react-dom.production.min.js:50
Mr @ react-dom.production.min.js:105
Jt @ react-dom.production.min.js:75
Zt @ react-dom.production.min.js:74
t.unstable_runWithPriority @ scheduler.production.min.js:18
$i @ react-dom.production.min.js:122
Ne @ react-dom.production.min.js:292
Qt @ react-dom.production.min.js:73
fetch.ts:62          POST https://matrix-client.matrix.org/_matrix/client/r0/join/!elPHPEplkxTcHJLIRR%3Afeneas.org 404
fetch @ fetch.ts:62
requestOtherUrl @ fetch.ts:264
request @ fetch.ts:205
authedRequest @ fetch.ts:156
joinRoom @ client.ts:3999
await in joinRoom (async)
dis.dispatch.action @ RoomViewStore.tsx:541
i @ promise.ts:39
joinRoom @ RoomViewStore.tsx:539
onDispatch @ RoomViewStore.tsx:297
t._invokeCallback @ Dispatcher.js:214
t.dispatch @ Dispatcher.js:189
setTimeout (async)
dispatch @ dispatcher.ts:52
(anonymous) @ RoomView.tsx:1467
Promise.then (async)
(anonymous) @ RoomView.tsx:1465
ze @ react-dom.production.min.js:52
Ye @ react-dom.production.min.js:52
(anonymous) @ react-dom.production.min.js:53
Dr @ react-dom.production.min.js:100
kr @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Pe @ react-dom.production.min.js:292
(anonymous) @ react-dom.production.min.js:50
Mr @ react-dom.production.min.js:105
Jt @ react-dom.production.min.js:75
Zt @ react-dom.production.min.js:74
t.unstable_runWithPriority @ scheduler.production.min.js:18
$i @ react-dom.production.min.js:122
Ne @ react-dom.production.min.js:292
Qt @ react-dom.production.min.js:73
rageshake.ts:73 !elPHPEplkxTcHJLIRR:feneas.org is current in RVS but missing from client - clearing sticky room

@t3chguy
Copy link
Member

t3chguy commented Feb 23, 2023

The request you're looking for is a /join request (given you clicked Join), the /initialSync request is done when you first navigate to the link in an attempt to preview the room if it is public & previewable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants