Skip to content

Invalid implementation of MSC3890 #23384

@t3chguy

Description

@t3chguy

While no local_notification_settings event exists for the current device, or a local_notification_settings event exists where is_silenced is falsy, events should be processed as normal and trigger system notifications and sounds where necessary.

Says to treat no event or no is_silenced as if it were false, we default to true: https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/utils/notifications.ts#L54

The wrong unstable prefix is used also org.matrix.msc3890.local_notification_settings vs https://github.com/matrix-org/matrix-spec-proposals/blob/60695654956019c51f88f0f88ca02280ef00bc13/proposals/3890-remote-local-notification-toggle.md#unstable-prefix

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions