-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-app link navigation broke on Element Nightly and develop #20715
In-app link navigation broke on Element Nightly and develop #20715
Comments
@thibaultamartin Could you provide more detail on the specific link you tried? On my first attempt, I was navigated inside Element, so it may come down to the precise link type. Feel free to message me privately if needed. |
For me this broke with a pill (from a bot, but rendered as a pill). See #20719 |
I can try to take a look tomorrow morning if no one picks this up before. |
It seems to be links to a message. For TWIM, my bot gives me a link to the messages people sent to report news. A typical link will be https://matrix.to/#/!QQpfJfZvqxbCfeDgCj:matrix.org/$yR7i-3aGQ_Ztbhj5wJAx_Gq6NBml8PX9gbIijD43UgU I just tested: links to a room (e.g. https://matrix.to/#/#sliding-sync:matrix.org) do work correctly |
I'll see what I can do here. |
This adds a fallback click handler for all links in the message to ensure that links that were ignored as part of linkification (e.g. pills, links in message content) will still navigate in-app where possible. This approach preserves a side-benefit of #7453, which kept all link hrefs as matrix.to style links (so that they can be easily copied and shared). Fixes element-hq/element-web#20715
This adds a fallback click handler for all links in the message to ensure that links that were ignored as part of linkification (e.g. pills, links in message content) will still navigate in-app where possible. This approach preserves a side benefit of #7453, which kept all link hrefs as matrix.to style links (so that they can be easily copied and shared). Fixes element-hq/element-web#20715
Steps to reproduce
Outcome
What did you expect?
I would expect Element to follow the matrix.to link
What happened instead?
The browser opens
Operating system
macOS
Application version
Element Nightly version: 2022012401
How did you install the app?
https://element.io/get-started#nightly
Homeserver
ergaster.org
Will you send logs?
Yes
The text was updated successfully, but these errors were encountered: