Broken screen sharing on Linux Wayland #18607
Comments
SimonBrandner
added
A-Electron
A-VoIP
O-Uncommon
|
@vchernin, I've submitted element-hq/element-desktop#256. I don't have a Wayland setup, so I can't really test this. In case you were able to try out the PR yourself and test it, it would be great. But don't worry about it if you don't know how to compile Element desktop/don't have time for it |
|
@SimonBrandner wow thanks for doing this so quickly! I do think your fix should work given it's the same as Jitsi's. I tried using recent work in Flatpak to build from source, but that wasn't as trivial I was hoping for. And I tried reading over the build instructions, but that might take me some time to figure it out... If anyone who is more familar with Electron can build this and try it out on Wayland please do. And then this should be mergeable :) |
|
I've merged the PR so this will be in tomorrow's nightly if you could give it a test. Follow instructions on https://element.io/get-started but instead of |
|
Re-opening since it's untested - let's close this once we know it works. |
You should also be able to do |
I'm not actually on Debian, but I can easily test this in a VM when it's ready. |
|
So I tested the current nightly build (to confirm what happens before the flag was added). But in a Ubuntu 21.04 VM I can't start video calls due to no camera access, I'm sure it's possible to pass it through somehow but that seems overkill. Is there a trick to override this error? Otherwise I'll just try in a live usb on real hardware. |
Not without tempering with the code, live USB is probably the easiest way |
|
But you should be able to screen-share in voice calls if both sides support it |
Thanks, will do.
Yeah, I'll just use my phone with latest stable Element as that already worked when I tried with stable Flatpak. |
|
@SimonBrandner I've just tested build Further info: The UX isn't perfect (as mentioned above) but it's much better than nothing. I'll open a follow up issue for improving that. Thanks again! |
-Don't need module since Element builds against Electron 13, which supports PipeWire 0.3 -PipeWire 0.3 is included in the runtime. -Mentioning the flag in the metainfo descrption will be redundant as of the next Element release, see element-hq/element-web#18607
-Don't need module since Element builds against Electron 13, which supports PipeWire 0.3 -PipeWire 0.3 is included in the runtime. -Mentioning the flag in the metainfo descrption will be redundant as of the next Element release, see element-hq/element-web#18607
-Don't need module since Element builds against Electron 13, which supports PipeWire 0.3 -PipeWire 0.3 is included in the runtime. -Mentioning the flag in the metainfo descrption will be redundant as of the next Element release, see element-hq/element-web#18607
Steps to reproduce
What happened?
Sharing the full screen or most apps will not work. You might in some cases be able to share other xwayland Chromium based apps, but that's a guess at best. This issue is not about group calls with embedded Jitsi, that is broken in all Element desktop builds due to element-hq/element-desktop#683.
What did you expect?
Chromium and Electron apps like Element currently require passing
--enable-features=WebRTCPipeWireCapturerat runtime to enable PipeWire screen sharing on Wayland. This isn't something most users will know exists, so screen sharing will simply be assumed to be broken with Element on Wayland.Element should enable this flag at build time so .DEB and Flatpak users can screen share. Jitsi meet electron did so here (not the Jitsi embedded in Element, just a seperate Electron Jitsi package).
As far as I've seen, this flag does not cause regressions for X11 users. The expererience with it on Wayland can sometimes have issues, but I think mostly working screen sharing on Wayland by default is better than hardly anything at all.
One issue I noticed is Element seems to have a similar problem as Jitsi Meet Electron, where the preview image is broken even though the share button works.
As discussed extensively here, when on Wayland, devices with dedicated gpus (notably AMD) might experience segfaults when using experimental (not fully enabled by default in any distro I know of) DMA-BUF PipeWire screencasting. Since DMA-BUF screencasting will not be fully enabled by default until issues discussed there are fixed, I don't see this as blocking for Element.
Operating system
Linux
Application version
Element version: 1.8.1 Olm version: 3.2.3
How did you install the app?
Flatpak, will affect DEB as well.
Have you submitted a rageshake?
No
The text was updated successfully, but these errors were encountered: