Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New session toast shows up even if you aren't on cross-signing #11921

Closed
turt2live opened this issue Jan 17, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3865
Closed

New session toast shows up even if you aren't on cross-signing #11921

turt2live opened this issue Jan 17, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3865
Labels
A-E2EE-Cross-Signing X-Release-Blocker

Comments

@turt2live
Copy link
Member

@jryans
Copy link
Collaborator

jryans commented Jan 17, 2020

This was recently merged as part of #11218. We should ensure it follows the lab before the next release.

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 17, 2020
@dbkr
Move feature flag check for new session toast
c7ddba7 
Forgot the path where it checks on startup. Just put it in recheck which covers everything.

Fixes element-hq/element-web#11921
@dbkr dbkr mentioned this issue Jan 17, 2020
Merged
@jryans jryans added the phase:1 label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE-Cross-Signing X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move feature flag check for new session toast matrix-org/matrix-react-sdk
2 participants
@jryans @turt2live