Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email notifications - either digest or realtime to tell you when you've missed a bing/invite/etc. #108

Closed
ara4n opened this issue Aug 30, 2015 · 13 comments

Comments

@ara4n
Copy link
Member

ara4n commented Aug 30, 2015

No description provided.

@ara4n ara4n added the feature label Aug 30, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@ara4n
Copy link
Member Author

ara4n commented Dec 20, 2015

This is higher priority than P3 - see also SYN-169. It's a really important way to keep people engaged with Vector.

@ara4n ara4n added P2 and removed P3 labels Dec 20, 2015
@ara4n
Copy link
Member Author

ara4n commented Dec 20, 2015

I won't make it block v0 though.

@AmandineLP AmandineLP modified the milestones: v1 - Private Preview, Ragnarok, v0 - Friendly Beta Jan 21, 2016
@AmandineLP
Copy link
Contributor

Proposed specs, can be discussed and completed:

image

To reduce spam we can consider sending email notifs for bing only to users having been idle/offlline sonce a given time.

@kegsay
Copy link
Contributor

kegsay commented Jan 22, 2016

I won't make it block v0 though.

Removed from v0

@AmandineLP AmandineLP added P1 and removed P2 labels Feb 3, 2016
@ara4n
Copy link
Member Author

ara4n commented Feb 18, 2016

Notes from discussing this with Amandine this morning:

  • If the user has been idle for at least 2 minutes, highlight/sound notifs trigger an email notif.
  • We batch email notifs together, with exponential back-off retry schedule per conversation.
  • If there is a significant pause in a conversation (say 4x the current retry interval?), we reset its exponential backoff timer.
  • New conversations start a new retry schedule... but we batch all pending notifs into a single email, effectively preempting a retry for older conversations. This doesn't reset the retry timer for those older conversations.

I wonder if this means we need the daily digest ones? Perhaps they can be implemented as an entirely separate mechanism. I find them quite annoying, and would probably prefer that we only spam people with updates when something new has actually happened (and these can contain the same overview stats as a digest would...)

@AmandineLP
Copy link
Contributor

Don't forget invites in the above. I guess it can be just a single email everytime someone invites you, even if he used your mxid, and if don't join in the next 4 (?) minutes. (see table)

I wouldn't want to have metrics like who joined rooms and how many unread msg there are in the notifs emails sent for highlight/sound or invites, but once a day it would be interesting. So I'm still quite keen on keeping the daily digest if something new happen only and which would include:

  • unread messages in favourite rooms

  • List of people who joined my favourite rooms
  • List of pending invites

However I understand the spam concern, so an option would be to deploy first the notifications and see how spammy it feels and then add the digest on a second step

@ara4n
Copy link
Member Author

ara4n commented Feb 18, 2016

(We've agreed that for now invites & messages should have the same idle timer before email notifs kick in - 2 mins for now)

@ara4n
Copy link
Member Author

ara4n commented Feb 18, 2016

One refinement that came up when discussing with dave & erik just now: rather than sending if the user has been idle for 2 minutes, we should probably wait for 2 minutes (or whatever the retry timer is) of inactivity after seeing the event before sending the email. If the user wakes up and uses the app, we should discard any pending email notifs and probably reset the timer schedule. This stops us from spamming the user if they're actually responding to push notifs elsewhere.

We could reduce the minimum timer to 0s if we know the user isn't polling and has no pushers set up, but that's a bit of an edge case.

@ara4n
Copy link
Member Author

ara4n commented Feb 25, 2016

There are now designs for this in basecamp.

@eternaleye
Copy link

I'd really prefer separating this from hilight/sound notifications - as a case in point, I use Vector on the bus over cellular + tethering. However, there are various dead spots, some of which last for 5min or so.

The instant I exit the dead spot, I'm alerted to new messages and invites by my phone, due to exactly hilight/sound notifications - but in the mean time, Vector may have sent me emails that are really just so much spam.

@ara4n
Copy link
Member Author

ara4n commented Mar 25, 2016

(see also https://matrix.org/jira/browse/SYN-169)

@dbkr
Copy link
Member

dbkr commented Mar 31, 2016

Have tried to summarise requirements on https://docs.google.com/document/d/1ZNxBMb9zoJNRZ12T-3_OCMgrcb3KhppTDaXtls1uDYs/edit

@ara4n
Copy link
Member Author

ara4n commented May 24, 2016

this is pretty much live now.

@ara4n ara4n closed this as completed May 24, 2016
t3chguy added a commit that referenced this issue Oct 17, 2024
* Use Compound close icon in favour of mishmash of x/close icons

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update snapshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Remove stale CSS

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update snapshot

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants