Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking the reactions button causes flashing #10222

Closed
turt2live opened this issue Jul 1, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3169
Closed

Clicking the reactions button causes flashing #10222

turt2live opened this issue Jul 1, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3169
Assignees
@jryans
Labels
A-Aggregations A-Reactions T-Defect

Comments

@turt2live
Copy link
Member

The scrollbar on the timeline disappears and comes back, the highlight on the message flashes, and the tooltip itself flashes. fwiw my first instinct is to try and click the button
@turt2live turt2live changed the title Clicking the reactions button causing flashing Clicking the reactions button causes flashing Jul 1, 2019
@bwindels
Copy link
Contributor

bwindels commented Jul 1, 2019 •
edited
Loading

I've had it happen several times to me as well, could just not close the tooltip when clicking?

@turt2live
Copy link
Member Author

that would be an ideal solution. I think a lot of the tooltip bugs from my part are because there's an invisible full-page div which is used to close the tooltip (which also means the hover state is lost, hence the flickering from #10179)

@jryans
Copy link
Collaborator

jryans commented Jul 1, 2019

Right, we could remove click to close. It was added as a conservative escape hatch of sorts.

I believe we still need some kind of transparent div watching mouse position since we're keeping the tooltip open when inside a safe area that is larger than the tooltip itself. Open to suggestions for another way to do this that also preserves hover... 😄

@turt2live
Copy link
Member Author

can we just listen on document instead?

@jryans
Copy link
Collaborator

jryans commented Jul 1, 2019

Ah yeah, maybe! 😅 I'll give it a try. I probably borrowed too much from other tooltips when making this one...

@jryans jryans self-assigned this Jul 1, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 1, 2019
@jryans
Improve interactive tooltip hover behaviour
3acdf27 
This gives the interactive tooltip a more natural hover behaviour by removing
the full screen div behind it. This allows the target button to keep its hover
state, for example.

This also removes the click to close behavior, which was too easy to trigger
accidentally.

Fixes element-hq/element-web#10179
Fixes element-hq/element-web#10222
Fixes element-hq/element-web#10225
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 1, 2019
@jryans
Improve interactive tooltip hover behaviour
dd94bf7 
This gives the interactive tooltip a more natural hover behaviour by removing
the full screen div behind it. This allows the target button to keep its hover
state, for example.

This also removes the click to close behaviour, which was too easy to trigger
accidentally.

Fixes element-hq/element-web#10179
Fixes element-hq/element-web#10222
Fixes element-hq/element-web#10225
@jryans jryans mentioned this issue Jul 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Reactions T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve interactive tooltip hover behaviour matrix-org/matrix-react-sdk
3 participants
@bwindels @jryans @turt2live