-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VoIP: Stop falling back to Google for STUN #10173
Comments
We need to decide whether to replace the fallback server with something else (to preserve the same likelihood that VoIP calls can be completed) or remove the fallback entirely and hope for the best. |
It would be good enough to have Google STUN fallback as an option set to False. if a call fails then the user can choose to enable the option if they wish. cc @ara4n |
We also decided to use our own stun server as a fallback rather than google's. Remaining questions:
|
Current thinking is:
This issue may apply both to making and receiving calls. |
we need to make clear that falling back to matrix.org is a hail mary which may not work (when giving them the option) and the right fix is for their server to configure turn |
After a huddle conclusions are:-
Separately we will create a tool to help admins trouble shoot their TURN config matrix-org/synapse#1519 |
Just to clarify, we'll be offering |
This changes the STUN fallback server from a Google server to one hosted at `turn.matrix.org`. Part of element-hq/element-web#10173
This changes ICE server fallback to be disabled by default. The SDK consumer will receive a new event in case the homeserver has no ICE servers of its own, and can prompt the user to agree to the fallback if desired. Part of element-hq/element-web#10173
This adds a prompt at the start of each session when the homeserver does not have any ICE servers configured. The fallback ICE server is only used if the user allows it. The dialog also recommends notifying the homeserver admin to rectify the issue. Fixes element-hq/element-web#10173
This changes the ICE server fallback to be disabled by default. The SDK consumer will receive a new event in case the homeserver has no ICE servers of its own, and can prompt the user to agree to the fallback if desired. Part of element-hq/element-web#10173
We have agreed to change the time of the prompt:
|
After discussion with @nadonomy, we'll use the following dialog text for the prompt:
|
Not sure the simplification works here - it's not that you can't make calls, but that it will be unreliable. And this text implies that using the public Matrix server will magically fix, which it probably won't. Let's simplify things by only showing the warning after a call fails. We don't care if TURN is misconfigured before a call if that call then goes on to work. How about:
(Edited to add "your homeserver" - @jryans) |
This adds a prompt at the start of each session when the homeserver does not have any ICE servers configured. The fallback ICE server is only used if the user allows it. The dialog also recommends notifying the homeserver admin to rectify the issue. Fixes element-hq/element-web#10173
From riot-ios created by manuroe: element-hq/element-ios#2532
Stop using any hardcoded fallback URL in the SDK.
The text was updated successfully, but these errors were encountered: