Description
@erikjohnston and I just spotted a new source of stuck notifications and other excitement with reactions... 😖
In a encrypted room, reactions are currently encrypted just like other events and end up with the message type m.room.encrypted. The default push rules for encrypted DM rooms notify for any message of type m.room.encrypted, so this will include reactions in such rooms.
Riot should now be advancing your read receipt past reactions (thus clearing the stuck notification), but @erikjohnston has observed this not working at least in one test case. (Further investigation is needed work out what the bug is here.)
On related note, it is a bit silly that apply the typical encryption path to reactions (including content ciphertext and setting the type to m.room.encrypted) because the relation data is sent around in the clear anyway. (We have separate future plans to specially encrypt just the reaction key.) It also prevents the server from aggregation reactions altogether, as it currently is watching for events with type m.reaction, but that won't be true in an encrypted room.